Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

579 - ODS-Module - About initialization #584

Merged
merged 47 commits into from
Oct 2, 2023
Merged

579 - ODS-Module - About initialization #584

merged 47 commits into from
Oct 2, 2023

Conversation

paulinea
Copy link
Member

No description provided.

@paulinea paulinea linked an issue Jul 20, 2023 that may be closed by this pull request
ODS-Module - About - Step1: Creation #579
Closed
@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for ods-android ready!

Name Link
🔨 Latest commit 22dd722
🔍 Latest deploy log https://app.netlify.com/sites/ods-android/deploys/650d4f4ed95d0500086978e3
😎 Deploy Preview https://deploy-preview-584--ods-android.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paulinea paulinea force-pushed the 579-ods-module-about-step1-creation branch from 99eca85 to b45cd6a Compare July 21, 2023 14:17
@paulinea paulinea force-pushed the 579-ods-module-about-step1-creation branch from b1400da to 8060ebc Compare August 8, 2023 12:23
@paulinea paulinea force-pushed the 579-ods-module-about-step1-creation branch 2 times, most recently from d739feb to 4c99f05 Compare September 12, 2023 12:50
@paulinea paulinea force-pushed the 579-ods-module-about-step1-creation branch from 4f48246 to 22dd722 Compare September 22, 2023 08:24
@paulinea paulinea changed the base branch from develop to 19-ods-module-about September 22, 2023 12:52
@paulinea paulinea marked this pull request as ready for review September 22, 2023 12:53
florentmaitre and others added 10 commits September 22, 2023 15:07
@florentmaitre
[#634] Fix background color of components in dark mode
7d4e3d9
@paulinea
Merge pull request #640 from Orange-OpenSource/634-bug-exposed-dropdo…
cc23e4a 
…wn-menu-backgound-changed-to-surface-in-015

634 - [Bug]: Exposed Dropdown Menu backgound changed to 'surface' in 0.15
@florentmaitre @paulinea
[#635] Fix a bug where the modifier was not taken into account in Ods…
ee9b626 
…OutlinedTextField
@paulinea
Merge pull request #637 from Orange-OpenSource/635-bug-odstextfield-p…
94ae6a4 
…ractically-not-usable-as-sizing-or-positioning-constraints-are-not-honored

635 - [Bug]: OdsTextField practically not usable as sizing or positioning constraints are not honored
@florentmaitre
[#623] Remove Kotlin reflect dependency
273340b
@florentmaitre
[#623] Use FlowRow from Androidx and remove Accompanist Flow Layout d…
b695f1c 
…ependency
@florentmaitre
[#623] Review: Update changelog
a024d98
@paulinea
Merge pull request #644 from Orange-OpenSource/623-reduce-library-size
a98f1b3 
623 - Reduce library size
@paulinea
Prepare 0.15.1 release
b52b0dc
@florentmaitre
Merge pull request #645 from Orange-OpenSource/prepare-release
87c6d06 
Prepare release 0.15.1
florentmaitre
florentmaitre reviewed Sep 28, 2023
View reviewed changes
...about/src/main/java/com/orange/ods/module/about/configuration/OdsAboutModuleConfiguration.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/MainScreen.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/MainState.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/modules/Module.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ods/app/ui/modules/ModuleDetailColumn.kt Show resolved Hide resolved
module-about/src/main/java/com/orange/ods/module/about/utilities/extension/ContextExt.kt Outdated Show resolved Hide resolved
module-about/src/main/java/com/orange/ods/module/about/utilities/extension/WebViewExt.kt Show resolved Hide resolved
module-about/src/main/java/com/orange/ods/module/about/OdsAboutFileScreen.kt Outdated Show resolved Hide resolved
module-about/src/main/res/drawable-xxxhdpi/il_about.png Outdated Show resolved Hide resolved
module-about/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@paulinea paulinea force-pushed the 579-ods-module-about-step1-creation branch from 4c92955 to 1695698 Compare September 28, 2023 13:43
@paulinea
[#579] Review: Move "view demo" button in ModuleDetailColumn
a973c0c
@paulinea
[#579] Review: Remove useless BundleCompat
f198492
@paulinea
[#579] Review: Fix typo
6ec6dad
@paulinea
[#579] Review: Use library plugin and remove coreKtx dependency
9ee15d7
@paulinea
[#579] Review: Set configuration to non nullable
a225cde
@paulinea
[#579] Review: Rename property
1a91f22
@paulinea
[#579] Review: Simplify expression
a1d9696
@paulinea
[#579] Review: Set launchUrl Context extension to internal
82c31da
@paulinea
[#579] Review: Set WebView.injectLightDarkModeCss() internal
eab821a
@paulinea
[#579] Review: Set OdsAboutFileScreen internal
2bc2ade
@paulinea
[#579] Review: Rename strings
73da481
@paulinea
[#579] Review: Add a NavHostController subclass to manage navigation …
b77e3c6 
…in the application
@paulinea
[#579] Review: Convert objects to data objects
142c05f
@paulinea
[#579] Review: Add preview for OdsAboutMainScreen
fe05cab
@paulinea
[#579] Review: Provide a version helper to help users generating a di…
da17b14 
…splayable version from package information
@paulinea
[#579] Review: Add il_about.png in mdpi directory
863286e
@paulinea
[#579] Review: Add contentScale parameter to DetailScreenHeader and c…
ff586bf 
…hange generic about illustrations
@paulinea
[#579] Review: Use NavController extensions instead of a subclass of …
d1ff017 
…NavController
@florentmaitre florentmaitre merged commit f422590 into 19-ods-module-about Oct 2, 2023
4 checks passed
@florentmaitre florentmaitre deleted the 579-ods-module-about-step1-creation branch October 2, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentmaitre florentmaitre florentmaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ODS-Module - About - Step1: Creation
2 participants
@paulinea @florentmaitre